(WIP) feat: LWE #177
Open
(WIP) feat: LWE #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't replicate the failing test locally. Maybe an issue with toolchain? |
Maybe rerun the tests, |
|
It's so odd. Drives me kinda crazy. |
mrdaybird
suggested changes
Jan 15, 2025
Comment on lines
+156
to
+162
| let dist_to_q_half = if result >= q_half { | ||
| // If result ≥ q/2, distance is min(result - q/2, q - result + q/2) | ||
| (result - q_half).min(-result + q_half) | ||
| } else { | ||
| // If result < q/2, distance is min(q/2 - result, result + q/2) | ||
| (q_half - result).min(result + q_half) | ||
| }; |
There was a problem hiding this comment.
Is this needed?
I think (result - q_half) <= (-result + q_half) for result >= q_half, and (q_half - result) <= (result + q_half) for result < q_half, is always true. I also did a quick check if this is ever not true for test_encryption_decryption.
Maybe you could verify this?
Maybe this could be distilled to:
Suggested change
| let dist_to_q_half = if result >= q_half { | |
| // If result ≥ q/2, distance is min(result - q/2, q - result + q/2) | |
| (result - q_half).min(-result + q_half) | |
| } else { | |
| // If result < q/2, distance is min(q/2 - result, result + q/2) | |
| (q_half - result).min(result + q_half) | |
| }; | |
| let dist_to_q_half = (result - q_half).min(q_half - result); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Plaintext?)